livekit / livekit-helm

LiveKit Helm charts
https://docs.livekit.io
Apache License 2.0
50 stars 59 forks source link

use arm64 compatible docker image for startup script #29

Closed JacobSteelsmith closed 2 years ago

JacobSteelsmith commented 2 years ago

This should fix #21 . I've created a helm package manually from the repository and installed it to an AWS cluster. The pod shows running in kubectl and the logs show the script ran. The tag for the image is the most recent that supports arm64. I have not tested this on a amd64 setup.

CLAassistant commented 2 years ago

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.


Jacob Steelsmith seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account.
You have signed the CLA already but the status is still pending? Let us recheck it.

davidzhao commented 2 years ago

Hey @JacobSteelsmith, sorry for the delays in reviewing this. after doing load testing, it doesn't appear we would need to modify these kernel settings. I'm testing a PR right now. If it performs similarly, we'll remove this startup script from the chart.

sawariz0r commented 2 years ago

It runs on my arm64 k3s cluster (4x pi4s) after making the suggested changes

davidzhao commented 2 years ago

Thanks for your contributions @sawariz0r. We've actually ended up stop using the daemonset, as the sysctl tuning isn't necessary with the latest livekit.