livekit / livekit-helm

LiveKit Helm charts
https://docs.livekit.io
Apache License 2.0
50 stars 59 forks source link

Add ingress annotations value #30

Closed benjamin658 closed 2 years ago

benjamin658 commented 2 years ago

Hi, I'm trying to deploy the chart to our EKS cluster, and there is a practical open-source project ExternalDNS that can synchronize DNS records, however, it needs to add some annotations to the ingress.

This is also useful if the user wants to add more AWS Load Balancer Controller annotations, for example, alb.ingress.kubernetes.io/group.name for saving load balancer costs.

Possible solution

Add loadBalancer.annotations value to allow adding custom annotations to the ingress.

https://github.com/livekit/livekit-helm/blob/3c43414cc5f3edbeb2719b52e3a5b6f0c8bdc940/livekit-server/values.yaml#L37-L39

https://github.com/livekit/livekit-helm/blob/3c43414cc5f3edbeb2719b52e3a5b6f0c8bdc940/livekit-server/templates/ingress.yaml#L10-L27

I am willing to make a PR if this is ok.