search

livekit / livekit-helm

LiveKit Helm charts
https://docs.livekit.io
Apache License 2.0
55 stars 64 forks source link

modify nginx ingress to support kubernetes >= 1.18 #35

Closed hiteshgarg14 closed 2 years ago

hiteshgarg14 commented 2 years ago

I was trying to set up on DigitalOcean but SSL was not working. Later, I found that the syntax was changed in the new Kubernetes API. After making the changes mentioned in this PR, I could get SSL working.

Reference: https://kubernetes.io/blog/2020/04/02/improvements-to-the-ingress-api-in-kubernetes-1.18/#setting-a-default-ingressclass

CLAassistant commented 2 years ago

CLA assistant check
All committers have signed the CLA.

davidzhao commented 2 years ago

@hiteshgarg14 thanks for the PR. I'll integrate the suggestions into the Helm chart. since I'm modifying it for other purposes.