fix: avoid mounting certificates when using external tls

livekit / livekit-helm

LiveKit Helm charts

https://docs.livekit.io

Apache License 2.0

50 stars 59 forks source link

fix: avoid mounting certificates when using external tls #40

Closed bmbferreira closed 2 years ago

bmbferreira commented 2 years ago

Fixes https://github.com/livekit/livekit-helm/issues/26

davidzhao commented 2 years ago

Thank you for the PR, this is a good fix! I'll test & merge this on Monday.

bmbferreira commented 2 years ago

@davidzhao sorry to bother you, but did you have any time to test it?

Btw, I also opened another PR that is a "quick win". It's sometimes annoying having to manually rotate all the pods after updating some config on the helm chart 😅

Please let me know how can I help to move both PRs forward 🙇 thank you!

davidzhao commented 2 years ago

@bmbferreira sorry for the delays here, I will test this out today!