search

livekit / livekit-helm

LiveKit Helm charts
https://docs.livekit.io
Apache License 2.0
50 stars 59 forks source link

Turn load balancer with external TLS #45

Closed serhatperkmen closed 1 year ago

serhatperkmen commented 2 years ago

Hi, is there any specific reason for the if statement for the below code?

https://github.com/livekit/livekit-helm/blob/8f91315c7a38bf785226e3f069328aa4b55c17ac/livekit-server/templates/turnloadbalancer.yaml#L12-L15

I am deploying it behind a L4 load balancer where the TLS terminates. So that I set external_tls to true. Because of the if statement, the service is created as ClusterIP and ExternalDNS is not adding a record to Route53.

In the previous version there was no if statement. That is added with this commit.

davidzhao commented 2 years ago

Which kubernetes provider are you using? With some providers, the load balancer created with a Service type LoadBalancer isn't always an L4 LB.

So instead we are making this more customizable for the user, you can place a custom Ingress in front of the service to configure that Ingress/LB.

bmbferreira commented 1 year ago

I'm also facing this issue. I want to terminate TLS at the load balancer. I'm running on EKS with aws load balancer controller.

bmbferreira commented 1 year ago

If we want to make it more customisable for the user, IMO the type for the service should be parameterised: https://github.com/livekit/livekit-helm/pull/49

serhatperkmen commented 1 year ago

Hi @davidzhao and @bmbferreira,

I am also running on EKS with AWS load balancer controller. I strongly agree your PR @bmbferreira. The type should be loadBalancer.