livekit / livekit-helm

LiveKit Helm charts
https://docs.livekit.io
Apache License 2.0
50 stars 59 forks source link

Make TURN service type configurable #49

Closed bmbferreira closed 1 year ago

bmbferreira commented 1 year ago

This makes the service type for TURN completely configurable from the client side, making no assumptions about provider, external tls, etc. Fixes #45.

davidzhao commented 1 year ago

Thank you for the PR! Could you also update server-sample so others would know how to use it?

bmbferreira commented 1 year ago

Thank you for the PR! Could you also update server-sample so others would know how to use it?

thanks for the quick feedback! 🙇 Just added it!

bmbferreira commented 1 year ago

Thanks for merging the fix @davidzhao ! 🙇 Do you think it would be possible to make a new release of the helm chart please?

Thank you!

davidzhao commented 1 year ago

Yup, will cut a release in the next day or so, along with a new server release. stay tuned!