livekit / livekit-helm

LiveKit Helm charts
https://docs.livekit.io
Apache License 2.0
55 stars 64 forks source link

what is the egress gcp.credentials_json value supposed to look like? #62

Open stevenaldinger opened 1 year ago

stevenaldinger commented 1 year ago

I was expecting it to be a file path with a volume mount but then saw the deployment template has no volume mounts.

From: https://github.com/livekit/livekit-helm/blob/master/egress-sample.yaml#L30-L31

Is this supposed to be raw JSON content like the following snippet? I'll happily open a PR that adds more clarity to the example if you can help me out.

egress:
  gcp:
    credentials_json: |
      {
        ...my JSON key contents...
      }
    bucket: my-bucket
davidzhao commented 1 year ago

Yeah, it should contain the contents of the credentials JSON that GCP gives you. Your example is the right way of embedding it here.