search

livekit / livekit-helm

LiveKit Helm charts
https://docs.livekit.io
Apache License 2.0
55 stars 64 forks source link

Feature request: generate API key/secret and store it in a Secret #7

Open a-type opened 3 years ago

a-type commented 3 years ago

The idea for this is inspired by charts I've used for database deployments - usually the credentials for the database can be generated for you during the deploy and stored in a Secret.

The nice part about this behavior is you don't have to worry about manually setting up the secret for your API server also running in the cluster; you can set up the API server deployment to reference the secret generated by the Livekit release by name with an expectation that it will be present and kept in sync even if Livekit is redeployed.

The only wrinkle might be if the format or generation of the keys is particular in some way such that it can't be generated on-the-fly during the templating (like how Neo4J does it). A cursory look at the server codebase seems to indicate it's just random strings though, so this might work?

cristianrat commented 2 years ago

Would also say, this applies to the redis part. For example, I don't want my redis password in git Which means, the values file can't be in git Which means, I can't use argocd to deploy this - not something that I want to do (or not do)