search

livekit / livekit-helm

LiveKit Helm charts
https://docs.livekit.io
Apache License 2.0
55 stars 64 forks source link

Make Ingress optional and ingressClass configurable #98

Open p4block opened 8 months ago

p4block commented 8 months ago

A bigger rework of the chart comes to my mind but this suffices for my usecase. Should be compatible with previous installs with no intervention.

Commenting on related things, fully decoupling the helmchart from gke/aws/do would be optimal, as there's really nothing that actually ties LiveKit to them. Ingress should also be decoupled from the loadbalancer, as TLS-terminating LBs can avoid the need for one if the user configured them but other people may use service+ingress instead.

Bringing up the chart to ie. Bitnami standard to allow fully changing every parameter would be a lot of work but ultimately desirable. I totally understand this may be out of scope for the chart and "users bring their your own yaml" may be preferred.

CLAassistant commented 8 months ago

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.

Pablo Moyano seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account.
You have signed the CLA already but the status is still pending? Let us recheck it.

wrenix commented 7 months ago

the ingress is optional withloadBalancer.type="disable" ...

PS: i really dislike that schema loadBalancer instatt of ingress and type: disabled instatt of enabled: true/false. but maybe we should not create two schema for the same thing