livekit / livekit-server-sdk-python

LiveKit Server SDK for Python
Apache License 2.0
26 stars 6 forks source link

Support for identity.name #1

Closed ghost closed 1 year ago

ghost commented 1 year ago

Hi and thanks for making this I'm using it and works fine for me Wanted to ask if I'm missing something or this feature isn't supported:

When you create a token, along with the identity and other stuff, you can also give that user a name (in the participant info) https://docs.livekit.io/server/room-management/#participantinfo

That name is used in the front-end displayName = participant.name || participant.identity; But I don't see anywhere in this package the name For example, this php package seems to have it https://github.com/agence104/livekit-server-sdk-php/blob/f6965a4d593356ffa762648c4acbb2cbfe048251/src/AccessToken.php#L89 I presume it's a new feature of livekit, perhaps

AlexJMohr commented 1 year ago

Looks like the participant name was added in v0.15.2: https://github.com/livekit/livekit/releases/tag/v0.15.2

I'll update to the latest livekit version soon!

ghost commented 1 year ago

Looks like the participant name was added in v0.15.2: https://github.com/livekit/livekit/releases/tag/v0.15.2

I'll update to the latest livekit version soon!

thanks for your quick reply that would be awesome, thank you :)

AlexJMohr commented 1 year ago

@crisrat Just released v0.4.0. Let me know if it works for you.

ghost commented 1 year ago

Already in use Works as expected Thank you so much

On Thu, 1 Dec 2022, 21:38 Alex Mohr, @.***> wrote:

@crisrat https://github.com/crisrat Just released v0.4.0. Let me know if it works for you.

— Reply to this email directly, view it on GitHub https://github.com/tradablebits/livekit-server-sdk-python/issues/1#issuecomment-1334480518, or unsubscribe https://github.com/notifications/unsubscribe-auth/ABGKRGPJFGKFE5N3TZ5ZPQTWLELELANCNFSM6AAAAAASRBQUYU . You are receiving this because you were mentioned.Message ID: @.***>