search

livekit / protocol

LiveKit protocol. Protobuf definitions for LiveKit's signaling protocol
https://docs.livekit.io
Apache License 2.0
71 stars 61 forks source link

lazily initialize pion loggers #689

Closed paulwe closed 4 months ago

paulwe commented 4 months ago

pion loggers are 9% of our heap objects in some regions and only produce a small number of error logs (2.6% of logs). i suspect most of them are never used. if this is true we can save ~7% of heap objects by deferring the bulk of initialization until we need to log something.

changeset-bot[bot] commented 4 months ago

⚠️ No Changeset found

Latest commit: 0dafc97021326994054919de037d8ee6198b7312

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

💥 An error occurred when fetching the changed packages and changesets in this PR ``` Some errors occurred when validating the changesets config: The package or glob expression "github.com/livekit/protocol" specified in the `fixed` option does not match any package in the project. You may have misspelled the package name or provided an invalid glob expression. Note that glob expressions must be defined according to https://www.npmjs.com/package/micromatch. ```