livekit / protocol

LiveKit protocol. Protobuf definitions for LiveKit's signaling protocol
https://docs.livekit.io
Apache License 2.0
68 stars 61 forks source link

Simplify number matching rules. Make '+' optional. #737

Closed dennwc closed 1 month ago

dennwc commented 1 month ago

Quite a few support questions from customers regarding SIP are made because of a tiny mistake in the number format in their Trunks. Twilio requires leading +, while Telnyx omits it by default.

This change makes + always optional for inbound calls. We will still accept the call if the Trunk has + set, but INVITE omits it (and vise versa).

In addition, make effort to fix outbound calls (CreateSIPParticipant requests) too by checking the base domain in SIP URI. It's not perfect and won't work if provider changes the domain. But it will help avoid most common problems.

changeset-bot[bot] commented 1 month ago

🦋 Changeset detected

Latest commit: 31369d962e1d625e1665752d610bb324a86c8ea6

The changes in this PR will be included in the next version bump.

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

💥 An error occurred when fetching the changed packages and changesets in this PR ``` Some errors occurred when validating the changesets config: The package or glob expression "github.com/livekit/protocol" specified in the `fixed` option does not match any package in the project. You may have misspelled the package name or provided an invalid glob expression. Note that glob expressions must be defined according to https://www.npmjs.com/package/micromatch. ```