search

livekit / protocol

LiveKit protocol. Protobuf definitions for LiveKit's signaling protocol
https://docs.livekit.io
Apache License 2.0
73 stars 62 forks source link

Get time inside lock. #742

Closed boks1971 closed 3 months ago

boks1971 commented 3 months ago

There was a very small window (I think) where if entries are getting reset around the same time, the time ordering could get reversed in the queue. Not a big issue, but was chasing something else and noticed this window and thought of making the change.

changeset-bot[bot] commented 3 months ago

⚠️ No Changeset found

Latest commit: 37d8bbad57d57851bd93b8292c6dc2e26f816693

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

💥 An error occurred when fetching the changed packages and changesets in this PR ``` Some errors occurred when validating the changesets config: The package or glob expression "github.com/livekit/protocol" specified in the `fixed` option does not match any package in the project. You may have misspelled the package name or provided an invalid glob expression. Note that glob expressions must be defined according to https://www.npmjs.com/package/micromatch. ```
paulwe commented 3 months ago

this is an intentional tradeoff to avoid putting the syscall in the critical section. the accuracy is limited by the polling rate which is always slow - usually several seconds.

boks1971 commented 3 months ago

Ah got it. Closing this then.