search

livekit / protocol

LiveKit protocol. Protobuf definitions for LiveKit's signaling protocol
https://docs.livekit.io
Apache License 2.0
71 stars 61 forks source link

Add `DisconnectReason` to `ParticipantInfo`. #788

Closed boks1971 closed 1 month ago

boks1971 commented 1 month ago

@lukasIO Last time, I did not create a changeset. Is there a specific step to create that? Do I need to run pnpm changeset in the repo?

changeset-bot[bot] commented 1 month ago

🦋 Changeset detected

Latest commit: d4cd579f9a74d4d82cf0a30e3860e318dced294b

The changes in this PR will be included in the next version bump.

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

💥 An error occurred when fetching the changed packages and changesets in this PR ``` Some errors occurred when validating the changesets config: The package or glob expression "github.com/livekit/protocol" specified in the `fixed` option does not match any package in the project. You may have misspelled the package name or provided an invalid glob expression. Note that glob expressions must be defined according to https://www.npmjs.com/package/micromatch. ```
lukasIO commented 1 month ago

Do I need to run pnpm changeset in the repo?

the command to add a changeset would be

pnpm changeset add

the CLI will guide you through the steps. For this repo it's best to select "all packages" to be affected by protocol changes.

boks1971 commented 1 month ago

@dennwc Going to merge this for now. We can add more reasons in a subsequent PR.

@davidzhao Please let us know if you have further thoughts on SIP disconnect reason Denys mentioned and if you have ideas on how to do that? Enhance DisconnectReason or a different method. That would involve client sending the reason with LeaveRequest, server interpreting it and plumbing that through.