livekit / protocol

LiveKit protocol. Protobuf definitions for LiveKit's signaling protocol
https://docs.livekit.io
Apache License 2.0
80 stars 70 forks source link

Replace protoyaml with fully opensource analog #863

Open T3RR7 opened 1 month ago

T3RR7 commented 1 month ago

This PR proposes replacement for buflint's protoyaml library as it's impossible to use LiveKit in some regions due the buflint policy. The solution I found originally belongs to this guy. All tests had passed.

UPD: There's useful side effect - getting rid of buflint's protoyaml dependencies

changeset-bot[bot] commented 1 month ago

⚠️ No Changeset found

Latest commit: 5fd919c519d34ebf9f4f3dc3693fbd2c19ef738f

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

💥 An error occurred when fetching the changed packages and changesets in this PR ``` Some errors occurred when validating the changesets config: The package or glob expression "github.com/livekit/protocol" specified in the `fixed` option does not match any package in the project. You may have misspelled the package name or provided an invalid glob expression. Note that glob expressions must be defined according to https://www.npmjs.com/package/micromatch. ```
CLAassistant commented 1 month ago

CLA assistant check
All committers have signed the CLA.

T3RR7 commented 1 month ago

Note: I noticed that some test failed. This is not related to this PR, all tests had passed locally on my PC with the same command used in CI. Also I checked out the test that failed and quickly run it with debugger, marshaller hasn't even been called.

davidzhao commented 1 month ago

Could you elaborate what about buflint's policy that makes it impossible to use?

don't worry about the failing test, one of the test can be a bit flakey :(

T3RR7 commented 1 month ago

Could you elaborate what about buflint's policy that makes it impossible to use?

Of course. It's impossible to use buflint in Russia and Belorussia.

I'm sure that the professional community should stay out of any political conflicts, but the buflint doesn't think so, saying "No Russian and Belorussian people, you are bad! I forbid to lint your go code!"

It's impossible to access their solutions located in their infrastructure without VPN or GOPROXY. Therefore, it's impossible to use any LiveKit open source tools and libraries due to how go dependencies work.

T3RR7 commented 1 month ago

@davidzhao ping :) What do you think?