search

livekit / protocol

LiveKit protocol. Protobuf definitions for LiveKit's signaling protocol
https://docs.livekit.io
Apache License 2.0
80 stars 70 forks source link

chore: support CJS #883

Closed nbsp closed 1 week ago

nbsp commented 2 weeks ago

this PR changes the CI to run two protobuf generators, one for each, plus another for dts. currently untested.

changeset-bot[bot] commented 2 weeks ago

⚠️ No Changeset found

Latest commit: c89b867670d6d8aacb41f88ebc128b4e492a41c1

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

💥 An error occurred when fetching the changed packages and changesets in this PR ``` Some errors occurred when validating the changesets config: The package or glob expression "github.com/livekit/protocol" specified in the `fixed` option does not match any package in the project. You may have misspelled the package name or provided an invalid glob expression. Note that glob expressions must be defined according to https://www.npmjs.com/package/micromatch. ```
nbsp commented 2 weeks ago

tested working on livekit-server-sdk (which breaks for a different reason, will be handled there, this part is fine)

lukasIO commented 2 weeks ago

before merging this, it would be great if we could test and verify the ESM and CJS behaviour with the most common bundlers/frameworks

nbsp commented 1 week ago

tested building downstream with esbuild (agents + tsup)