search

livekit / protocol

LiveKit protocol. Protobuf definitions for LiveKit's signaling protocol
https://docs.livekit.io
Apache License 2.0
80 stars 70 forks source link

Revert "chore(deps): bump go to 1.23" #905

Closed davidzhao closed 5 days ago

davidzhao commented 5 days ago

Reverts livekit/protocol#885

Since this package is depended on by others (including external users). we should not raise Go version requirements too aggressively.

changeset-bot[bot] commented 5 days ago

🦋 Changeset detected

Latest commit: 4d748b184f7ed06a9a3f995eb94d22646f841a39

The changes in this PR will be included in the next version bump.

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

💥 An error occurred when fetching the changed packages and changesets in this PR ``` Some errors occurred when validating the changesets config: The package or glob expression "github.com/livekit/protocol" specified in the `fixed` option does not match any package in the project. You may have misspelled the package name or provided an invalid glob expression. Note that glob expressions must be defined according to https://www.npmjs.com/package/micromatch. ```
rektdeckard commented 5 days ago

I believe the bump was to fix build issues in some part of closed-source due to dependency on 1.23 features (indirectly). It may be a dependency we can replace, though.

davidzhao commented 5 days ago

I believe the bump was to fix build issues in some part of closed-source due to dependency on 1.23 features (indirectly). It may be a dependency we can replace, though.

I think it's a dependency for counterfeiter/v6, it's compiling now after I lowered the version.. let's see if downstream deps would error again