search

livekit / python-sdks

LiveKit real-time and server SDKs for Python
https://docs.livekit.io
Apache License 2.0
127 stars 37 forks source link

Improvements to VideoFrame and publish_track APIs #144

Closed davidzhao closed 8 months ago

davidzhao commented 8 months ago

Using defaults instead of requiring users to pass in these parameters.

This is a breaking change. We'll need to release 0.8.0 afterwards.

davidzhao commented 8 months ago

We could avoid the breaking change by removing the *. Tho nit otherwise lgtm, ty for the docstr

the order of args is still different though.. so I think it'd break either way? Just thinking that it'll only get harder to modify the API.. so might as well do it now 😛

theomonnom commented 8 months ago

Oh right, didn't see it