search

livekit / python-sdks

LiveKit real-time and server SDKs for Python
https://docs.livekit.io
Apache License 2.0
95 stars 33 forks source link

Allow asynchronous event callbacks #41

Closed dguerizec closed 1 year ago

dguerizec commented 1 year ago

In the current code, event callbacks cannot be async. This PR is meant to be able to define async event callbacks.

CLAassistant commented 1 year ago

CLA assistant check
All committers have signed the CLA.

theomonnom commented 1 year ago

Hey, thank you for your PR! Are we sure the events are still ordered with AsyncIOEventEmitter?

dguerizec commented 1 year ago

Mmmm, probably not. I'll check my use case again to see if I absolutely need this.

dguerizec commented 1 year ago

Closing since I realized it's not necessary.