search

livekit / rust-sdks

LiveKit realtime and server SDKs for Rust
https://livekit.io
Apache License 2.0
206 stars 51 forks source link

Allow to create ParticipantSid from String in user module #250

Closed trzeciak closed 11 months ago

trzeciak commented 11 months ago

Hey, I want test/use this livekit-rust-sdk in c++ code. To do this I create internal-rust-layer to expose some functionality, and extract it to c++. I came across a problem to create ParticipantSid from String in user module, therefore i purpose to add 'pub' in declaration of this type:

pub struct ParticipantSid(String);
pub struct ParticipantSid(pub String);

Do you think it is ok, or I should choose other way?

theomonnom commented 11 months ago

Answered in https://github.com/livekit/rust-sdks/pull/251