Closed dennwc closed 5 months ago
make sure to bump minor on all affected crates. not familiar enough with the rest of the codebase to do a full review
let's not bump for this PR, we need more stuff before bumping this version
I'm not sure the change for attributes is complete. I couldn't find any code that updated
name
ormetadata
based on update events. So not sure where I should add attributes updates 🤔
Are you talking about these events? https://github.com/livekit/rust-sdks/blob/9c2a467751f1698532393bee95b96cba71af78b3/livekit/src/room/mod.rs#L119C5-L119C31
These too! Need to create a new one there :+1:
But also, aren't these events supposed to update ParticipantInfo
in the SDK? I haven't found any place that updates metadata
based on received signaling updates.
@theomonnom I added the update handler too. Not sure if it's a good idea to clone the new metadata for the changed callback :thinking:
Update protocol. Quite a few changes:
enable_transcoding
for Ingress.I'm not sure the change for attributes is complete. I couldn't find any code that updated
name
ormetadata
based on update events. So not sure where I should add attributes updates :thinking: