livekit / rust-sdks

LiveKit realtime and server SDKs for Rust
https://livekit.io
Apache License 2.0
211 stars 56 forks source link

Fix enconding presets #464

Open iparaskev opened 1 month ago

iparaskev commented 1 month ago

Fixes an issue with compute_appropriate_encoding, where the last preset in the list with the highest FPS wasn't considered.

Changes the order in into_rtp_encodings to have the highest quality first.

CLAassistant commented 1 month ago

CLA assistant check
All committers have signed the CLA.

iparaskev commented 1 month ago

Hi, first of all thanks for the project.

I have a question regarding the "rid" when the presets are only 2 in into_rtp_encodings. Should they be

  1. "q" and "h"
  2. "q" and "f"
  3. "h" and "f"

?

Thanks