search

livekit / rust-sdks

LiveKit realtime and server SDKs for Rust
https://livekit.io
Apache License 2.0
212 stars 57 forks source link

Use proto2 syntax for FFI #470

Closed lukasIO closed 1 month ago

lukasIO commented 1 month ago

yeah, there's a couple of messages (callbacks with results) that I changed to be a oneof message of either error or result, so that's a change that has to be accounted for

lukasIO commented 1 month ago

I think this is what's needed: https://github.com/livekit/python-sdks/pull/290 (some type additions in there to make catching errors easier)

theomonnom commented 1 month ago

nice, any drawbacks we should be aware of when using the proto2 syntax? e.g performance decrease, .. otherwise lgtm, this is much cleaner on the rust side!

lukasIO commented 1 month ago

not that I'm aware of, though performance will always depend on the language specific encoders and decoders

bcherry commented 1 month ago

next time can we wait to merge something substantial like this until we have updates ready to go for all of the dependent SDKs? this is now blocking development of new FFI-based changes in node and python