search

livekit / webrtc-xcframework

MIT License
2 stars 10 forks source link

RTCAudioDevice "initialize(with delegate:" method is not called #1

Open ronnyf opened 9 months ago

ronnyf commented 9 months ago

When creating an RTCPeerConnection with RTCAudioDevice parameter:

RTCPeerConnectionFactory(encoderFactory: encoderFactory, decoderFactory: decoderFactory, audioDevice: audioDevice)

The audio device class gets instantiated correctly, but the method initialize(with delegate: RTCAudioDeviceDelegate) -> Bool is never called. Might this have something to do with your custom RTCDefaultAudioProcessingModule ?

Could you please put some higher priority on fixing this? 🙏

hiroshihorie commented 9 months ago

Hello @ronnyf !

This is a known issue which has been reported before : https://github.com/webrtc-sdk/webrtc/pull/94

I want to fix this eventually but since we don't use this route at the moment the priority is not high. Our WebRTC code is located here: https://github.com/webrtc-sdk/webrtc It would be great if you could figure out a non-breaking way to fix this, I believe it isn't complicated.