search

livepeer / LIPs

Livepeer Improvement Proposals
9 stars 13 forks source link

LIP-25: update spec with additional details #37

Closed kyriediculous closed 4 years ago

kyriediculous commented 4 years ago

Update the spec to reflect the latest implementation details in https://github.com/livepeer/protocol/pull/383

kyriediculous commented 4 years ago

fixed in c1d6b61

On Wed, Jul 15, 2020 at 9:26 PM Yondon Fu notifications@github.com wrote:

@yondonfu requested changes on this pull request.

In LIPs/LIP-25.md https://github.com/livepeer/LIPs/pull/37#discussion_r455289066:

-Stage an update for execution, can consist of multiple separate updates to be executed atomically as a batch. The array of signatures should be respective to update which it matches. The updates have to be signed by the contract owner. +Execute updates that were previously staged for execution. Execute will revert if the update has not been staged prior or the delay hasn't expired.

Looks like there is an extra space b/w "previously" and "staged".

In LIPs/LIP-25.md https://github.com/livepeer/LIPs/pull/37#discussion_r455289247:

-Execute updates that were previously staged for execution, reverts if the delay has not expired. +Upon succesful execution of an _update , it's hash will be removed from the updates map to prevent replay.

Looks like there is an extra space after _update.

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/livepeer/LIPs/pull/37#pullrequestreview-449263821, or unsubscribe https://github.com/notifications/unsubscribe-auth/AFJZZWUZQC4BLVARUCMZU5DR3X7GXANCNFSM4O2ZXS2A .