livepeer / catalyst-api

MIT License
4 stars 2 forks source link

Emit metrics after segmenting failure #386

Closed thomshutt closed 1 year ago

thomshutt commented 1 year ago

Currently if Mist fails early enough (i.e we catch the failure in one of the triggers), we don't write any metric to Prometheus.

mjh1 commented 1 year ago

@thomshutt I looked at an example of this in prod and saw that after the "segmenting failed" error we then get a log line "Finished job and deleted from job cache" from here where we also emit the vod pipeline metrics so doesn't that mean we're covered? Or are we saying we want an extra metric to say specifically "segmenting failure", that could be a tag on the existing metrics i guess.

Vod example from loki

thomshutt commented 1 year ago

@mjh1 Great! Sounds like this was maybe fixed during the pipeline work then - I'll close