livepeer / catalyst-api

MIT License
4 stars 2 forks source link

Update output video response to Studio #419

Closed emranemran closed 1 year ago

emranemran commented 1 year ago

Follow-up on Victor's comment from here: https://github.com/livepeer/catalyst-api/issues/400

mjh1 commented 1 year ago

So in line with @victorges's comment, reducing to a single output with optional hls and mp4 outputs, this is a first suggestion:

{
    "outputs": [
        {
            "type": "object_store",
            "manifest": "https://foo.bar/index.m3u8",
            "mp4_outputs": [
                {
                    "size": "123456",
                    "location": "https://foo.bar/static360p0.mp4",
                    "height": 123,
                    "width": 123,
                    "bitrate": 123
                },
                {
                    "size": "1234567",
                    "location": "https://foo.bar/static720p0.mp4",
                    "height": 123,
                    "width": 123,
                    "bitrate": 123
                }
            ]
        }
    ]
}

It also then makes it easy for consumers like studio to pick out the mp4 outputs. @victorges @emranemran @gioelecerati what do you guys think? cc @thomshutt

emranemran commented 1 year ago

Yep, I like this style.

@victorges / @gioelecerati, can you guys confirm?

victorges commented 1 year ago

@mjh1 @emranemran I like it too! Just to confirm we're aligned E2E: then the corresponding output_locations in the request would be a single entry with both transcoded_segments and auto_mp4s turned on, with the path set to the asset folder instead of a specific file (today, HLS index). Then catalyst figures out the relative paths and returns the full paths in that response. Is that it?

mjh1 commented 1 year ago

@mjh1 @emranemran I like it too! Just to confirm we're aligned E2E: then the corresponding output_locations in the request would be a single entry with both transcoded_segments and auto_mp4s turned on, with the path set to the asset folder instead of a specific file (today, HLS index). Then catalyst figures out the relative paths and returns the full paths in that response. Is that it?

Exactly, that's what I was thinking yep.

mjh1 commented 1 year ago

@victorges if we make these changes, is it only studio/task-runner code that will need updating, does it affect Chase at all on the sdk side?

victorges commented 1 year ago

@mjh1 I think only task-runner needs to change!