search

livepeer / catalyst-uploader

Livepeer cloud storage upload utility. Called by Mist to upload video segments. Has CLI interface.
1 stars 3 forks source link

Retries seemed to be causing zero byte files #40

Closed mjh1 closed 1 year ago

mjh1 commented 1 year ago

Need to save the contents of the input so that retries won't end up reading from an empty reader.

codecov[bot] commented 1 year ago

Codecov Report

Merging #40 (6879e76) into main (7d4f20b) will decrease coverage by 0.60108%. The diff coverage is 0.00000%.

Impacted file tree graph

@@                 Coverage Diff                 @@
##                main         #40         +/-   ##
===================================================
- Coverage   16.12903%   15.52795%   -0.60108%     
===================================================
  Files              2           2                 
  Lines            155         161          +6     
===================================================
  Hits              25          25                 
- Misses           121         127          +6     
  Partials           9           9
Files Coverage Δ
core/uploader.go 20.00000% <0.00000%> (-1.00840%) :arrow_down:

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 7d4f20b...6879e76. Read the comment docs.

Files Coverage Δ
core/uploader.go 20.00000% <0.00000%> (-1.00840%) :arrow_down: