livepeer / catalyst-uploader

Livepeer cloud storage upload utility. Called by Mist to upload video segments. Has CLI interface.
1 stars 3 forks source link

Increase retry delays #55

Closed mjh1 closed 9 months ago

mjh1 commented 9 months ago

We can sometimes see a short period of issues from storj, our existing retries were very close together (a few seconds in total) so would only catch extremely short periods of problems.

Also removing the fatal logging since it prints huge goroutine traces into our logging

codecov[bot] commented 9 months ago

Codecov Report

Attention: 10 lines in your changes are missing coverage. Please review.

Comparison is base (567aec3) 16.84783% compared to head (ce56e5c) 16.75676%.

Additional details and impacted files [![Impacted file tree graph](https://app.codecov.io/gh/livepeer/catalyst-uploader/pull/55/graphs/tree.svg?width=650&height=150&src=pr&token=t5Wuk4k006&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=livepeer)](https://app.codecov.io/gh/livepeer/catalyst-uploader/pull/55?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=livepeer) ```diff @@ Coverage Diff @@ ## main #55 +/- ## =================================================== - Coverage 16.84783% 16.75676% -0.09107% =================================================== Files 2 2 Lines 184 185 +1 =================================================== Hits 31 31 - Misses 145 146 +1 Partials 8 8 ``` | [Files](https://app.codecov.io/gh/livepeer/catalyst-uploader/pull/55?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=livepeer) | Coverage Δ | | |---|---|---| | [core/uploader.go](https://app.codecov.io/gh/livepeer/catalyst-uploader/pull/55?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=livepeer#diff-Y29yZS91cGxvYWRlci5nbw==) | `23.30827% <0.00000%> (ø)` | | | [catalyst-uploader.go](https://app.codecov.io/gh/livepeer/catalyst-uploader/pull/55?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=livepeer#diff-Y2F0YWx5c3QtdXBsb2FkZXIuZ28=) | `0.00000% <0.00000%> (ø)` | | ------ [Continue to review full report in Codecov by Sentry](https://app.codecov.io/gh/livepeer/catalyst-uploader/pull/55?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=livepeer). > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=livepeer) > `Δ = absolute (impact)`, `ø = not affected`, `? = missing data` > Powered by [Codecov](https://app.codecov.io/gh/livepeer/catalyst-uploader/pull/55?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=livepeer). Last update [567aec3...ce56e5c](https://app.codecov.io/gh/livepeer/catalyst-uploader/pull/55?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=livepeer). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=livepeer). | [Files](https://app.codecov.io/gh/livepeer/catalyst-uploader/pull/55?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=livepeer) | Coverage Δ | | |---|---|---| | [core/uploader.go](https://app.codecov.io/gh/livepeer/catalyst-uploader/pull/55?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=livepeer#diff-Y29yZS91cGxvYWRlci5nbw==) | `23.30827% <0.00000%> (ø)` | | | [catalyst-uploader.go](https://app.codecov.io/gh/livepeer/catalyst-uploader/pull/55?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=livepeer#diff-Y2F0YWx5c3QtdXBsb2FkZXIuZ28=) | `0.00000% <0.00000%> (ø)` | |