livepeer / explorer

https://explorer.livepeer.org
9 stars 11 forks source link

feat: make delegation widget accessible from My Account view when wallet is connected #254

Closed adamsoffer closed 9 months ago

adamsoffer commented 10 months ago

This PR ensures that the delegation widget is accessible from the "My Account" view when a user's wallet is connected to the explorer. Resolves issue #243

vercel[bot] commented 10 months ago

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
explorer-arbitrum-goerli ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jan 12, 2024 4:43pm
explorer-arbitrum-one ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jan 12, 2024 4:43pm
rickstaa commented 9 months ago

@adamsoffer, thanks again for implementing this ❤️‍🔥. I tested the changes, and they are working on my local machine. I think the code is cleanly executed and can be merged. However, I made one small suggestion that could improve the mobile delegate/undelegated behaviour (see https://github.com/livepeer/explorer/pull/255). Your old versions would only show the delegate button on the mobile view:

image

The new behavoir shows both buttons and opens the related delegator widget tab accordingly:

image

adamsoffer commented 9 months ago

Thanks @rickstaa! Nice spot - just merged your PR into this branch.