search

livepeer / explorer

https://explorer.livepeer.org
9 stars 11 forks source link

ROI should account for treasuryRewardCutRate #257

Closed rickstaa closed 7 months ago

rickstaa commented 9 months ago

Problem Description

In the watercooler chat of 15-01-2024, Arunas identified a critical issue regarding the current system's ROI (Return on Investment) calculation. It appears that the calculation fails to consider the 'reward cut' allocated to the treasury, as established by the decision detailed at Livepeer Explorer. This oversight could lead to inaccuracies in ROI reporting, potentially impacting user expectations and financial planning.

Proposed Solution

To resolve this, adjusting the ROI calculation to include the treasuryRewardCutRate is essential. This adjustment should be made in the calculateROI function, which can be found in the Livepeer Explorer's GitHub repository.

The treasuryRewardCutRate can be sourced from the bondingManager's readProxyContract method on ArbiScan. Alternatively, this data could be integrated into the Livepeer Subgraph for easier access and implementation.

Incorporating this change will ensure a more accurate and trustworthy ROI calculation, aligning it with the recent protocol updates and maintaining the integrity of our financial reporting.

rickstaa commented 9 months ago

@adamsoffer, @0xcadams I had 30 minutes of free time, and I created a quick draft to address this issue -> https://github.com/livepeer/explorer/pull/258.

rickstaa commented 7 months ago

This was fixed in https://github.com/livepeer/explorer/pull/258.