Fixes - Githubissues

livepeer / file-video

https://file.video

79 stars 14 forks source link

Fixes #10

Closed rajgoesout closed 3 years ago

rajgoesout commented 3 years ago

Minor fixes

Now the video quality switches also works on browsers that have native HLS support (Safari, mobile phone)
Handle the edge case when video upload fails

vercel[bot] commented 3 years ago

@rajdeepbharati is attempting to deploy a commit to the Livepeer Team on Vercel.

A member of the Team first needs to authorize it.

vercel[bot] commented 3 years ago

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/livepeerorg/file-video/m12rrcac1
✅ Preview: https://file-video-git-fixes.livepeerorg.vercel.app

adamsoffer commented 3 years ago

Thanks @rajdeepbharati, these fixes look good 🙏. I noticed with the resolution switcher includes a "0p" resolution option. Should this be removed?

rajgoesout commented 3 years ago

The "0p" is the source video quality. We kept it for now since there wasn't a direct way to hide that in the frontend. Is that okay?

adamsoffer commented 3 years ago

@rajdeepbharati no prob. If you figure out a straight forward way to hide it let me know.