search

livepeer / go-PPSPP

Go implementation of the Peer-to-Peer Streaming Peer Protocol (rfc7574)
MIT License
11 stars 4 forks source link

Keypairs #11

Open sricketts opened 7 years ago

sricketts commented 7 years ago

Code review comment (PR #8) from @dob regarding:

priv, pub, _ := crypto.GenerateKeyPair(crypto.RSA, 2048)

Note for the future that we may want to use an ECDSA keypair to match the ethereum ecosystem. Then again, I had a discussion this week about the need for a less computationally expensive encryption method for low latency streaming. I'm not familiar enough with the alternatives. I could see us using the ECDSA secp256k1 curve for handshake and key exchange in the kademlia "tracker" discovery, and then using something lighter for PPSPP.

sricketts commented 7 years ago

Next step for me would be to get a better understanding of the NewBasicHost code (which comes from an example) and then read up on these other crypto options.

dob commented 7 years ago

Yah, this is not a top priority for now, since we can likely just change the crypto with one line of code later when we have the right design for it.