search

livepeer / go-livepeer-basicnet

Basic p2p video streaming for Livepeer
MIT License
18 stars 8 forks source link

TranscodeSub #38

Closed j0sh closed 6 years ago

j0sh commented 6 years ago

Squashed version of https://github.com/livepeer/go-livepeer-basicnet/pull/32

Code/contents should otherwise be identical; verify with git diff ja/transcodesub ja/transcodesub-squashed

j0sh commented 6 years ago

Fixed the old bug with cancel here https://github.com/livepeer/go-livepeer-basicnet/pull/38/commits/a9bf5fad8f94ff4a7a9c4edc77d22aec6672cecf (note that the relay mapping key was incorrect as well). Note that I kept the commit standalone since it's unrelated to the transcodesub changes.

As of now, the global go test suite doesn't even actually pass locally; it is failing on another older test for no discernible reason. If running each test-file manually, eg make basic_network_test && make integration_test && make libp2p_playground_test && make network_node_test && make data_test && make transcode_sub_test then things usually pass (but not always). I think the overall issue is less with CircleCI slowness and more to do with inherent issues either in libp2p, our tests, or something in between. This is something we need to address at some point.

ericxtang commented 6 years ago

@j0sh for the short term, let's change the circle script to run each file manually.

j0sh commented 6 years ago

Updated to use the new libp2p, however circle is failing once again. The same test command works locally.

j0sh commented 6 years ago

CircleCI appears to be passing now, but not much changed. 🎉 ❓

j0sh commented 6 years ago

Added another fix for a separate basicnet crash that was found during testing. https://github.com/livepeer/go-livepeer-basicnet/pull/38/commits/34c59028b4e80d9e897700d8b6ccaa5e26d37edd

ericxtang commented 6 years ago

This is a pretty big PR, and the network architecture has changed since we made this design. I want to do a little manual testing on Rinkeby before having confidence in it.