livepeer / go-livepeer-basicnet

Basic p2p video streaming for Livepeer
MIT License
18 stars 8 forks source link

logging: Print abbreviated peer IDs. #47

Open j0sh opened 6 years ago

j0sh commented 6 years ago

Easier to distinguish and diagnose issues with rather than using the full hex-encoded address.

ericxtang commented 6 years ago

Hmm... This is gonna make it hard to match up with the StrmIDs, since it's composed of the full hex nodeID and a random byte array.

j0sh commented 6 years ago

Does that come in handy? Usually I'm looking at the logs between adjacent peers, which usually don't match the stream ID (bootnodes etc). If we do need to print the actual stream ID in places, then perhaps we should do it in abbreviated form as well (eg, by extracting the broadcaster nodeid).

ericxtang commented 6 years ago

🚢