search

livepeer / go-livepeer

Official Go implementation of the Livepeer protocol
http://livepeer.org
MIT License
546 stars 171 forks source link

Add arbitrum-one-goerli network and deprecate arbitrum-one-rinkeby #2664

Open leszko opened 1 year ago

leszko commented 1 year ago

As the livepeer cmd user, I'd like to use specify the -network arbitrum-one-goerli option in order to use start Livepeer node in the Arbitrum Devnet (Goerli) network.

Additionally, we should print a warning message if any deprecated network is used (arbitrum-one-rinkeby, mainnet, or rinkeby).

A new network can be added after the Livepeer contracts are deployed into Arbitrum Goerli. The network can be added here.

rickstaa commented 10 months ago

@leszko, the contracts have not yet been deployed to arbitrum-one-goerli, correct? What is the currently recommended way to test the binary without being interested in the main net?

Related to https://github.com/livepeer/go-livepeer/issues/2937.

leszko commented 10 months ago

I think we don't have contracts deployed in Goerli. Neither in any testnet. @victorges may know better the current status. Victor, are we deployed on any chain other than Arbitrum Mainnet?

One option is to test against the locally deployed chain. Please check E2E Tests for details.

rickstaa commented 10 months ago

@leszko No problem. I was just double checking I already use the steps given in this guide to check if https://github.com/livepeer/go-livepeer/pull/2905 was correct 👍🏻.

victorges commented 10 months ago

@leszko from the Delta project we kept a testnet running which is still being used by this dev explorer: https://goerli-explorer.livepeer.monster/treasury

It was not considered an official "devnet" since it does not try to match what's in mainnet, rather it was used for protocol development purposes with multiple upgrades and temporary versions etc. If that's all we want, no reason not to just keep using it though. Though for go-livepeer development we probably want an actual devnet.

Some useful resources:

Also keep in mind that Goerli is begin decommissioned next month, so we don't want to invest much more on it anymore. It's successor is Arbitrum Sepolia so we should give preference to that for any new deployments.