search

livepeer / go-livepeer

Official Go implementation of the Livepeer protocol
http://livepeer.org
MIT License
546 stars 171 forks source link

`Successfully received results` does not print error #2779

Closed stronk-dev closed 1 year ago

stronk-dev commented 1 year ago

https://github.com/livepeer/go-livepeer/blob/db28a19f985cfb92cc87ed914c9087eaac37fd13/core/orchestrator.go#L808-L810

A small issue with an easy fix. It adds tries to print chanData.Err but there is no %s to actually print the error:

E0328 14:40:05.681459       1 segment_rpc.go:230] manifestID=92b1bh08xfhn7bze-test seqNo=9 orchSessionID=30830226 clientIP=138.199.4.164 sender=0xc3c7c4C8f7061B7d6A72766Eee5359fE4F36e61E Could not transcode err="Cannot allocate memory"
E0328 14:40:05.680645       1 orchestrator.go:569] manifestID=92b1bh08xfhn7bze-test seqNo=9 orchSessionID=30830226 clientIP=138.199.4.164 sender=0xc3c7c4C8f7061B7d6A72766Eee5359fE4F36e61E Error transcoding segName=https://207.246.83.222:8443/stream/30830226/9.tempfile err="Cannot allocate memory"
E0328 14:40:05.671685       1 orchestrator.go:822] manifestID=92b1bh08xfhn7bze-test seqNo=9 orchSessionID=30830226 clientIP=138.199.4.164 sender=0xc3c7c4C8f7061B7d6A72766Eee5359fE4F36e61E Successfully received results from remote transcoder=73.54.195.252:55406 segments=0 taskId=5588 fname=https://207.246.83.222:8443/stream/30830226/9.tempfile dur=747.337204ms err="Cannot allocate memory"
E0328 14:40:05.671585       1 ot_rpc.go:568] Transcoding error for taskId=5588 err="Cannot allocate memory"
E0328 14:40:05.671585       1 ot_rpc.go:568] Transcoding error for taskId=5588 err="Cannot allocate memory"
stronk-dev commented 1 year ago

Sorry I'm dumb, it does print it