Closed rickstaa closed 2 months ago
Attention: Patch coverage is 25.00000%
with 6 lines
in your changes are missing coverage. Please review.
Project coverage is 57.36267%. Comparing base (
7599f7f
) to head (a405b69
).
LGTM
I just wonder if we should also refactor all other places where we use the term "broadcaster". Like:
- E2E Test: https://github.com/livepeer/go-livepeer/blob/706ec33286344613ec37c4f0ac4d4f3d17657049/test/e2e/e2e.go#L256
- All the function names, tests, etc.
Saying that, I'm ok with keeping them as they are right now and just rename later when we'll be removing the
broadcaster
flag.
@leszko, on the AI side, we initially focused on introducing the --gateway
flag while deprecating the --broadcaster
flag to minimize changes compared to the master
branch. We can implement these changes on the master branch and then rebase the AI branch accordingly. 👍🏻
What does this pull request do? Explain your changes. (required)
This pull request adds the
gateway
flag and deprecates thebroadcaster
flag per core team decision (details: https://discord.com/channels/423160867534929930/1051963444598943784/1210356864643109004). It adds the new-gateway
flag while maintaining support for-broadcaster
with a deprecation warning on startup. This change does not address refactoring associated with variable names and types, which will be addressed in a later change.Specific updates (required)
-gateway
flagHow did you test each of these updates (required)
-gateway
flag-broadcaster
flag, noted deprecation warningDoes this pull request close any open issues?
AI-LIV-287
Checklist:
make
runs successfully./test.sh
passTestSubmitSegment_HttpPostError
server test does fails on my system but I don't think it is related to my changes since it also fails on the master branch (see logs below).Test Logs
```bash --- FAIL: TestSubmitSegment_HttpPostError (0.00s) segment_rpc_test.go:1708: Error Trace: /home/ricks/development/work/livepeer/ai_spe/go-livepeer/server/segment_rpc_test.go:1708 Error: "\r\n404 Not Found
404 Not Found