Closed rickstaa closed 1 month ago
Attention: Patch coverage is 20.00000%
with 4 lines
in your changes missing coverage. Please review.
Project coverage is 57.40929%. Comparing base (
e8f079e
) to head (95418ef
).
@victorges I noticed in https://github.com/livepeer/go-livepeer/pull/2981 hat you added the following line:
Since there's no goroutine or defer statement inside the loop that could cause a closure over the loop variable, we can safely remove the p := p
line I think.
Hey @rickstaa! Even tho there's no explicit go or defer statements there, there is a closure on this anonymous function sent to that auto updater: https://github.com/livepeer/go-livepeer/blob/b739f354ce42d20d51c0778156999932dd8c2ae8/cmd%2Flivepeer%2Fstarter%2Fstarter.go#L799
And that updater itself might start a goroutine that eventually runs that function.
Do you think this could be made clear in some way?
Hey @rickstaa! Even tho there's no explicit go or defer statements there, there is a closure on this anonymous function sent to that auto updater:
And that updater itself might start a goroutine that eventually runs that function.
Do you think this could be made clear in some way?
@victorges Ah, I think I had been programming for too long when I asked that question and overlooked the anonymous function 🤦🏻. Thanks for your explanation! I think in that case we are good to merge this 👍🏻.
What does this pull request do? Explain your changes. (required)
This pull request updates internal references from 'Broadcaster' to 'Gateway' in accordance with the core team’s decision. For more details, refer to the discussion: Discord Link.
It follows up on https://github.com/livepeer/go-livepeer/pull/3056 as I noticed I forgot to rename some references.
Specific updates (required)
livepeer.go
andstarter.go
files.How did you test each of these updates (required)
I checked the tests were successful and started a off-chain orchestrator and gateway.
Does this pull request close any open issues?
NO
Checklist:
make
runs successfully./test.sh
pass