livepeer / go-livepeer

Official Go implementation of the Livepeer protocol
http://livepeer.org
MIT License
537 stars 165 forks source link

Revert "ci: protect Docker 'stable' tag (#3062)" #3067

Closed leszko closed 1 month ago

leszko commented 1 month ago

Reverting your PR @rickstaa , because it stopped building docker images.

rickstaa commented 1 month ago

@leszko, my apologies for the confusion. The correct syntax is the one I used in the ai-video branch. It appears the last commit where I updated the syntax (as it was no longer functioning) was not included in the pull request to the main branch. You can view the commit here: link.

hjpotter92 commented 1 month ago

@leszko, my apologies for the confusion. The correct syntax is the one I used in the ai-video branch. It appears the last commit where I updated the syntax (as it was no longer functioning) was not included in the pull request to the main branch. You can view the commit here: link.

the default branch for this repo is not main 😅

rickstaa commented 1 month ago

@leszko, please feel free to merge this pull request or my new one: PR #3068. This one is working, as you can see from the successful actions run: link.

rickstaa commented 1 month ago

@leszko, my apologies for the confusion. The correct syntax is the one I used in the ai-video branch. It appears the last commit where I updated the syntax (as it was no longer functioning) was not included in the pull request to the main branch. You can view the commit here: link.

the default branch for this repo is not main 😅

Good catch will fix it now 👍🏻.

leszko commented 1 month ago

Cool, thanks @rickstaa . Merged your PR and closing this one.