livepeer / go-livepeer

Official Go implementation of the Livepeer protocol
http://livepeer.org
MIT License
542 stars 169 forks source link

Add ctx to logging for selection algorithm #3080

Closed leszko closed 3 months ago

leszko commented 3 months ago

This effectively adds manifestID to the logs.

Related to https://linear.app/livepeer/issue/ENG-2051/investigate-warnings-no-orchestrators-passed-max-price-filter

linear[bot] commented 3 months ago

ENG-2051 Investigate warnings "No Orchestrators passed max price filter"

victorges commented 3 months ago

Gotta update tests, I guess just the signature that broke from the test code

codecov[bot] commented 3 months ago

Codecov Report

Attention: Patch coverage is 80.00000% with 2 lines in your changes missing coverage. Please review.

Project coverage is 57.40929%. Comparing base (df4c106) to head (a01b36e).

Additional details and impacted files [![Impacted file tree graph](https://app.codecov.io/gh/livepeer/go-livepeer/pull/3080/graphs/tree.svg?width=650&height=150&src=pr&token=vKzl2rUYvB&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=livepeer)](https://app.codecov.io/gh/livepeer/go-livepeer/pull/3080?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=livepeer) ```diff @@ Coverage Diff @@ ## master #3080 +/- ## ============================================= Coverage 57.40929% 57.40929% ============================================= Files 92 92 Lines 15764 15764 ============================================= Hits 9050 9050 Misses 6111 6111 Partials 603 603 ``` | [Files](https://app.codecov.io/gh/livepeer/go-livepeer/pull/3080?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=livepeer) | Coverage Δ | | |---|---|---| | [common/types.go](https://app.codecov.io/gh/livepeer/go-livepeer/pull/3080?src=pr&el=tree&filepath=common%2Ftypes.go&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=livepeer#diff-Y29tbW9uL3R5cGVzLmdv) | `0.00000% <ø> (ø)` | | | [server/selection.go](https://app.codecov.io/gh/livepeer/go-livepeer/pull/3080?src=pr&el=tree&filepath=server%2Fselection.go&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=livepeer#diff-c2VydmVyL3NlbGVjdGlvbi5nbw==) | `93.10345% <100.00000%> (ø)` | | | [server/selection\_algorithm.go](https://app.codecov.io/gh/livepeer/go-livepeer/pull/3080?src=pr&el=tree&filepath=server%2Fselection_algorithm.go&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=livepeer#diff-c2VydmVyL3NlbGVjdGlvbl9hbGdvcml0aG0uZ28=) | `89.23077% <77.77778%> (ø)` | | ------ [Continue to review full report in Codecov by Sentry](https://app.codecov.io/gh/livepeer/go-livepeer/pull/3080?dropdown=coverage&src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=livepeer). > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=livepeer) > `Δ = absolute (impact)`, `ø = not affected`, `? = missing data` > Powered by [Codecov](https://app.codecov.io/gh/livepeer/go-livepeer/pull/3080?dropdown=coverage&src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=livepeer). Last update [df4c106...a01b36e](https://app.codecov.io/gh/livepeer/go-livepeer/pull/3080?dropdown=coverage&src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=livepeer). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=livepeer). | [Files](https://app.codecov.io/gh/livepeer/go-livepeer/pull/3080?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=livepeer) | Coverage Δ | | |---|---|---| | [common/types.go](https://app.codecov.io/gh/livepeer/go-livepeer/pull/3080?src=pr&el=tree&filepath=common%2Ftypes.go&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=livepeer#diff-Y29tbW9uL3R5cGVzLmdv) | `0.00000% <ø> (ø)` | | | [server/selection.go](https://app.codecov.io/gh/livepeer/go-livepeer/pull/3080?src=pr&el=tree&filepath=server%2Fselection.go&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=livepeer#diff-c2VydmVyL3NlbGVjdGlvbi5nbw==) | `93.10345% <100.00000%> (ø)` | | | [server/selection\_algorithm.go](https://app.codecov.io/gh/livepeer/go-livepeer/pull/3080?src=pr&el=tree&filepath=server%2Fselection_algorithm.go&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=livepeer#diff-c2VydmVyL3NlbGVjdGlvbl9hbGdvcml0aG0uZ28=) | `89.23077% <77.77778%> (ø)` | |