search

livepeer / go-tools

Utility packages used across Livepeer Go repositories.
0 stars 2 forks source link

Handle gracefully S3 objects without metadata #10

Closed leszko closed 1 year ago

leszko commented 1 year ago

fix https://github.com/livepeer/go-tools/issues/9

The initial problem was that Storj buckets don't contain ETags, which causes panic while using Transcode API.

I added a unit test, but I'm somewhere on the fence if we should have it or not. @cyberj0g if you have any opinion, let me know. For the context, it does not make sense to have the whole "upload' test for Storj, because files added with AWS SDK to Storj actually includes ETag, only the files which are uploaded using the native Storj CLI (uplink) lack ETags.

cyberj0g commented 1 year ago

LGTM! Let's include a unit test for this, even if it's not run by CI. It's easier to debug having one, plus it serves as a documentation.