search

livepeer / go-tools

Utility packages used across Livepeer Go repositories.
0 stars 2 forks source link

Remove unused methods #14

Open thomshutt opened 1 year ago

thomshutt commented 1 year ago

Confirm if IsExternal is used anywhere (i.e in other repos) and if so, document more clearly what its intended us is but otherwise remove.

Check other methods on the same interface.

https://github.com/livepeer/go-tools/blob/44cbd85855e79c9a8d9327598e0a95d9261c0351/drivers/drivers.go#L126

thomshutt commented 1 year ago

Looks like we do use it in a few places in go-livepeer, e.g https://github.com/livepeer/go-livepeer/blob/970d0aa7892cd9c30aaf069a7ee8e72d8fa64111/verification/epic.go#L191

so this task should just cover better documenting the intended usage