livepeer / go-tools

Utility packages used across Livepeer Go repositories.
0 stars 2 forks source link

drivers/s3: hazard a guess at region field from URL #29

Closed iameli closed 1 year ago

iameli commented 1 year ago

Look, is selecting the second segment of the domain name kind of arbitrary? Yeah. Should we also build in the ability to customize the region in from the OS string? Probably. But it's not like any OSses actually require the string "ignored", so I'd argue this change does no harm while "magically" making things start working for Wasabi users. Also anyone who uses the s3+https syntax for first-party S3 for whatever reason.

Works around #21