livepeer / livepeer-monorepo

JavaScript tools and applications that interact with Livepeer's smart contracts and peer-to-peer network
https://livepeer.org
MIT License
167 stars 71 forks source link

change default ordering to total fees earned #1026

Closed adamsoffer closed 2 years ago

adamsoffer commented 2 years ago

What does this pull request do? Explain your changes. (required) As proposed in this forum post, this PR changes the default ordering of the orchestrator leaderboard from total stake to total fees earned.

Screenshots (optional): image

vercel[bot] commented 2 years ago

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployments, click below or on the icon next to each commit.

explorer-mainnet – ./packages/explorer-2.0

🔍 Inspect: https://vercel.com/livepeer/explorer-mainnet/57j2kEEubxYUSRQGJKWY8JkMMve8
✅ Preview: https://explorer-mainnet-git-as-order-by-fee-livepeer.vercel.app

explorer-rinkeby – ./packages/explorer-2.0

🔍 Inspect: https://vercel.com/livepeer/explorer-rinkeby/fP1hPF7x7g9G7icLQdtZeiXjedw4
✅ Preview: https://explorer-rinkeby-git-as-order-by-fee-livepeer.vercel.app

papabear99 commented 2 years ago

With this change the "staking" tab now lists orchestrators by fees earned so I propose either adding a "fees earned" tab to allow sorting by fees earned, stake or performance, or if the intent is to not have the ability to list orchestrators by stake then change the "staking" tab to "fees earned" to reflect what the tab is actually showing.

Franck-UltimaRatio commented 2 years ago

Just an idea, It would be interesting to add a tab indicating the date when the node started to work (like on https://top-performers.vercel.app/) To know the efficiency of a node, it is necessary to make a link between earns / Stake / start date. That could also help future delegators to know the reliability over time of a node.