livepeer / lpms

Livepeer media server
MIT License
282 stars 71 forks source link

Update FFmpeg to 7.0.1 #406

Closed j0sh closed 1 month ago

j0sh commented 2 months ago

Updates to the latest ffmpeg release (7.0.1) and adjust unit tests to match some slightly changed behaviors in the CLI that is used for testing. This also uncovered a bug that was fixed as described in #405 but is also included in this PR (see commit message).

The unit tests all pass with zero timestamp adjustments, so this update should be reasonably backwards-compatible with older LPMS. In fact, the updated LPMS transcoder still passes the full test suite even when the test suite is running the old ffmpeg CLI. The unit test changes are only there to make the tests pass when running with the new CLI, mostly changes in a few ffprobe fields and command-line options.

Commits

Pre-Merge

Post-Merge

codecov[bot] commented 1 month ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 50.20216%. Comparing base (684658a) to head (d446d4f). Report is 7 commits behind head on master.

Additional details and impacted files [![Impacted file tree graph](https://app.codecov.io/gh/livepeer/lpms/pull/406/graphs/tree.svg?width=650&height=150&src=pr&token=sa1XWzLYHR&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=livepeer)](https://app.codecov.io/gh/livepeer/lpms/pull/406?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=livepeer) ```diff @@ Coverage Diff @@ ## master #406 +/- ## =================================================== + Coverage 49.88901% 50.20216% +0.31315% =================================================== Files 12 12 Lines 1802 1484 -318 =================================================== - Hits 899 745 -154 + Misses 852 689 -163 + Partials 51 50 -1 ``` [see 12 files with indirect coverage changes](https://app.codecov.io/gh/livepeer/lpms/pull/406/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=livepeer) ------ [Continue to review full report in Codecov by Sentry](https://app.codecov.io/gh/livepeer/lpms/pull/406?dropdown=coverage&src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=livepeer). > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=livepeer) > `Δ = absolute (impact)`, `ø = not affected`, `? = missing data` > Powered by [Codecov](https://app.codecov.io/gh/livepeer/lpms/pull/406?dropdown=coverage&src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=livepeer). Last update [343a3dd...d446d4f](https://app.codecov.io/gh/livepeer/lpms/pull/406?dropdown=coverage&src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=livepeer). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=livepeer). [see 12 files with indirect coverage changes](https://app.codecov.io/gh/livepeer/lpms/pull/406/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=livepeer)