pm: Change unlock period to be round based

livepeer / protocol

Livepeer protocol

MIT License

152 stars 45 forks source link

pm: Change unlock period to be round based #320

Closed yondonfu closed 5 years ago

yondonfu commented 5 years ago

This PR updates the unlock period to be round based which makes the unlock period consistent with other time based variables in the rest of the contracts. Furthermore, the addition of a withdrawRound for the sender allows us to prevent reserve claims after the sender's unlock period is over which avoids an edge case with a reserve's claimedForRound and claimedByAddress mappings not being cleared upon withdrawal round N and being non-zero after a funding operation in that same round.

coveralls commented 5 years ago

Pull Request Test Coverage Report for Build 848

7 of 7 (100.0%) changed or added relevant lines in 1 file are covered.
No unchanged relevant lines lost coverage.
Overall coverage increased (+0.002%) to 99.622%

Totals
Change from base Build 839:	0.002%
Covered Lines:	734
Relevant Lines:	735

💛 - Coveralls

yondonfu commented 5 years ago

Rebased with #319