Currently GenerickMock.sol uses a high-level version of the CALL opcode, which returns only whether the external call succeeded before solidity 0.5.0 , therefore we are currently not returning revert reasons to test for in the unit tests.
We could use a low-level inline assembly-snippet to make the external call, but since we'll be upgrading to solidity 0.5.0 we can make this change after the compiler upgrade. After that high-level implementation of CALL does return the return data as a second return value and we can change the GenericMock.execute function to:
Currently
GenerickMock.sol
uses a high-level version of theCALL
opcode, which returns only whether the external call succeeded before solidity 0.5.0 , therefore we are currently not returning revert reasons to test for in the unit tests.We could use a low-level inline assembly-snippet to make the external call, but since we'll be upgrading to solidity 0.5.0 we can make this change after the compiler upgrade. After that high-level implementation of
CALL
does return the return data as a second return value and we can change theGenericMock.execute
function to: