Improved test commands and misc file cleanup

livepeer / protocol

Livepeer protocol

MIT License

154 stars 45 forks source link

Improved test commands and misc file cleanup #344

Closed yondonfu closed 4 years ago

yondonfu commented 5 years ago

This PR updates test commands so that ganache-cli is started and cleaned up after each test command. This avoids the problem where whenever we update ganache-cli, if two versions are incompatible (EVM version change for example) and we accidentally connect to an old instance from a previous test command we end up running into weird issues. Also:

Cleans up package.json scripts
Removes some unneeded utility files
Adds space-infix-ops eslint rule since this has come up in some recent PR reviews

Fixes #316

yondonfu commented 4 years ago

Changed base branch to streamflow and rebased.

yondonfu commented 4 years ago

I'm guessing for the changes to the npm scripts to use package names instead of paths, that npm will first try to resolve those dependencies in node_modules/.bin before checking globally installed modules?

Yep! See https://firstdoit.com/no-need-for-globals-using-npm-dependencies-in-npm-scripts-3dfb478908

kyriediculous commented 4 years ago

~~Looks like the tests pass but coveralls throws an error at the end of the process~~

Saw on discord that coveralls is down

coveralls commented 4 years ago

Pull Request Test Coverage Report for Build 1104

0 of 0 changed or added relevant lines in 0 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage remained the same at 100.0%

Totals
Change from base Build 1092:	0.0%
Covered Lines:	681
Relevant Lines:	681

💛 - Coveralls

yondonfu commented 4 years ago

Coveralls fixed!