The Minter contract on the master branch uses the onlyBondingManagerOrJobsManager() and the onlyMinterOrJobsManager() modifiers, but the Minter contract on the streamflow branch uses the onlyBondingManagerOrTicketBroker() and the onlyMinterOrTicketBroker() modifiers. Since we will not be upgrading the Minter, we should rollback these changes so that the Minter uses the onlyBondingManagerOrJobsManager() and the onlyMinterOrJobsManager() modifiers (the end result will be that the Minter implementation will be logically the same and the only changes contained in the repo would be syntactical + for compiler versioning). In practice, the TicketBroker can be registered under the contract ID keccak256("JobsManager") - the TicketBroker will then be able to use the Minter to deposit/withdraw escrowed ETH without any modifications to the currently deployed Minter.
yondonfu
commented
4 years ago
The
Mintercontract on themasterbranch uses theonlyBondingManagerOrJobsManager()and theonlyMinterOrJobsManager()modifiers, but theMintercontract on thestreamflowbranch uses theonlyBondingManagerOrTicketBroker()and theonlyMinterOrTicketBroker()modifiers. Since we will not be upgrading theMinter, we should rollback these changes so that theMinteruses theonlyBondingManagerOrJobsManager()and theonlyMinterOrJobsManager()modifiers (the end result will be that theMinterimplementation will be logically the same and the only changes contained in the repo would be syntactical + for compiler versioning). In practice, theTicketBrokercan be registered under the contract IDkeccak256("JobsManager")- theTicketBrokerwill then be able to use theMinterto deposit/withdraw escrowed ETH without any modifications to the currently deployedMinter.